fix #494: add delete impact confirmations

This commit is contained in:
devmrko
2026-06-26 14:33:25 +09:00
parent c8326f954d
commit cacf7b2bc4
13 changed files with 383 additions and 25 deletions

View File

@@ -76,6 +76,22 @@ public class PermissionService {
@Transactional
public void deleteRole(long roleId) {
deleteRole(roleId, true);
}
@Transactional
public void deleteRole(long roleId, boolean confirmImpact) {
if (!confirmImpact) {
throw new AppException("역할 삭제 전 영향 확인이 필요합니다.");
}
int userRoleCount = permissionMapper.countUserRolesByRoleId(roleId);
int groupRoleCount = permissionMapper.countGroupRolesByRoleId(roleId);
int permissionCount = permissionMapper.countPermissionsByRoleId(roleId);
if (userRoleCount + groupRoleCount + permissionCount > 0) {
throw new AppException("연결된 사용자/그룹/권한이 있는 역할은 삭제할 수 없습니다. 사용자 역할 "
+ userRoleCount + "건, 그룹 역할 " + groupRoleCount + "건, 권한 " + permissionCount
+ "건을 먼저 해제하세요.");
}
int deleted = permissionMapper.deleteRole(roleId);
if (deleted == 0) {
throw new AppException("삭제할 역할을 찾을 수 없습니다.");
@@ -133,6 +149,14 @@ public class PermissionService {
@Transactional
public void deletePermission(long permissionId) {
deletePermission(permissionId, true);
}
@Transactional
public void deletePermission(long permissionId, boolean confirmImpact) {
if (!confirmImpact) {
throw new AppException("권한 삭제 전 영향 확인이 필요합니다.");
}
Long objectId = permissionMapper.findObjectIdByPermissionId(permissionId);
permissionMapper.deleteRules(permissionId);
permissionMapper.deleteVisibleColumns(permissionId);
@@ -147,6 +171,10 @@ public class PermissionService {
"permissionId=" + permissionId));
}
public int countPermissionsByObjectId(long objectId) {
return permissionMapper.countPermissionsByObjectId(objectId);
}
private void validateRules(long objectId, List<RuleCommand> rules) {
if (rules == null || rules.isEmpty()) {
throw new AppException("행 규칙은 하나 이상 필요합니다.");