[Developer] #424 stop guessing protected object ORDS paths

src/main/java/com/cloudhandson/vpdbackoffice/domain/protectedobject/DatabaseObjectOption.java

@@ -13,8 +13,4 @@ public record DatabaseObjectOption(
   public String label() {
     return owner + "." + objectName + " (" + objectType + ")";
   }
-
-  public String defaultOrdsPath() {
-    return owner.toLowerCase() + "/" + objectName.toLowerCase();
-  }
 }

src/main/java/com/cloudhandson/vpdbackoffice/mapper/ProtectedObjectMapper.java

@@ -34,5 +34,7 @@ public interface ProtectedObjectMapper {
                     @Param("columnName") String columnName,
                     @Param("sensitiveYn") String sensitiveYn);
 
+  int updateOrdsPath(@Param("objectId") long objectId, @Param("ordsPath") String ordsPath);
+
   int disableObject(@Param("objectId") long objectId);
 }

src/main/java/com/cloudhandson/vpdbackoffice/service/ProtectedObjectService.java

@@ -68,29 +68,8 @@ public class ProtectedObjectService {
     if (existing != null) {
       return existing;
     }
-    List<String> columns = mapper.findDatabaseColumns(owner, objectName);
+    throw new AppException("테이블/뷰 관리에서 실제 ORDS Path를 먼저 등록하세요: "
-    if (columns.isEmpty()) {
+        + owner.toUpperCase(Locale.ROOT) + "." + objectName.toUpperCase(Locale.ROOT));
-      throw new AppException("DB 객체 컬럼을 찾을 수 없습니다: " + owner + "." + objectName);
-    }
-    long objectId = mapper.nextObjectId();
-    mapper.insertObject(objectId, new ProtectedObjectCreateCommand(
-        owner,
-        objectName,
-        defaultOrdsPath(owner, objectName),
-        String.join(",", columns),
-        ""
-    ));
-    for (String column : columns) {
-      mapper.insertColumn(mapper.nextColumnId(), objectId, column, "N");
-    }
-    auditService.record(new AuditEvent("PROTECTED_OBJECT_CREATED", null, objectId, "SUCCESS", null, null,
-        owner + "." + objectName));
-    return mapper.findById(objectId);
-  }
-
-  private String defaultOrdsPath(String owner, String objectName) {
-    String schemaPath = owner.equalsIgnoreCase("CB_ORDS") ? "cb-ords" : owner.toLowerCase(Locale.ROOT);
-    return schemaPath + "/" + objectName.toLowerCase(Locale.ROOT);
   }
 
   private ProtectedObjectCreateCommand normalizeCreateCommand(ProtectedObjectCreateCommand command) {
@@ -98,7 +77,7 @@ public class ProtectedObjectService {
     String objectName = command.objectName().trim().toUpperCase(Locale.ROOT);
     String ordsPath = command.ordsPath();
     if (ordsPath == null || ordsPath.isBlank()) {
-      ordsPath = defaultOrdsPath(owner, objectName);
+      throw new AppException("ORDS Path는 실제 ORDS module/template 경로를 입력해야 합니다.");
     }
     String columns = command.columns();
     if (columns == null || columns.isBlank()) {
@@ -107,6 +86,19 @@ public class ProtectedObjectService {
     return new ProtectedObjectCreateCommand(owner, objectName, ordsPath.trim(), columns, command.sensitiveColumns());
   }
 
+  @Transactional
+  public void updateOrdsPath(long objectId, String ordsPath) {
+    if (ordsPath == null || ordsPath.isBlank()) {
+      throw new AppException("ORDS Path는 필수입니다.");
+    }
+    int updated = mapper.updateOrdsPath(objectId, ordsPath.trim());
+    if (updated == 0) {
+      throw new AppException("보호 객체를 찾을 수 없습니다.");
+    }
+    auditService.record(new AuditEvent("PROTECTED_OBJECT_ORDS_PATH_UPDATED", null, objectId, "SUCCESS", null, null,
+        ordsPath.trim()));
+  }
+
   @Transactional
   public void disableObject(long objectId) {
     int updated = mapper.disableObject(objectId);

src/main/java/com/cloudhandson/vpdbackoffice/web/ProtectedObjectController.java

@@ -1,6 +1,7 @@
 package com.cloudhandson.vpdbackoffice.web;
 
 import com.cloudhandson.vpdbackoffice.domain.protectedobject.ProtectedObjectCreateCommand;
+import com.cloudhandson.vpdbackoffice.service.AppException;
 import com.cloudhandson.vpdbackoffice.service.ProtectedObjectService;
 import org.springframework.stereotype.Controller;
 import org.springframework.ui.Model;
@@ -34,9 +35,28 @@ public class ProtectedObjectController {
       @RequestParam(required = false) String sensitiveColumns,
       RedirectAttributes redirectAttributes
   ) {
+    try {
       protectedObjectService.createObject(
           new ProtectedObjectCreateCommand(owner, objectName, ordsPath, columns, sensitiveColumns));
       redirectAttributes.addFlashAttribute("message", "보호 객체를 추가했습니다.");
+    } catch (AppException exception) {
+      redirectAttributes.addFlashAttribute("errorMessage", exception.getMessage());
+    }
+    return "redirect:/objects";
+  }
+
+  @PostMapping("/objects/ords-path")
+  public String updateOrdsPath(
+      @RequestParam long objectId,
+      @RequestParam String ordsPath,
+      RedirectAttributes redirectAttributes
+  ) {
+    try {
+      protectedObjectService.updateOrdsPath(objectId, ordsPath);
+      redirectAttributes.addFlashAttribute("message", "ORDS Path를 수정했습니다.");
+    } catch (AppException exception) {
+      redirectAttributes.addFlashAttribute("errorMessage", exception.getMessage());
+    }
     return "redirect:/objects";
   }
 

src/main/resources/mapper/ProtectedObjectMapper.xml

@@ -71,6 +71,12 @@
     VALUES (#{columnId}, #{objectId}, UPPER(#{columnName}), #{sensitiveYn})
   </insert>
 
+  <update id="updateOrdsPath">
+    UPDATE cb_protected_object
+    SET ords_path = #{ordsPath,jdbcType=VARCHAR}
+    WHERE object_id = #{objectId,jdbcType=NUMERIC}
+  </update>
+
   <update id="disableObject">
     UPDATE cb_protected_object
     SET enabled_yn = 'N'

src/main/resources/static/js/app.js

@@ -76,8 +76,8 @@ async function syncObjectCatalogSelection() {
   if (objectInput) {
     objectInput.value = selected.dataset.objectName || '';
   }
-  if (ordsPathInput) {
+  if (ordsPathInput && !ordsPathInput.value) {
-    ordsPathInput.value = selected.dataset.defaultPath || '';
+    ordsPathInput.focus();
   }
   if (!columnsInput) {
     return;

src/main/resources/templates/objects.html

@@ -10,6 +10,7 @@
   </div>
 
   <div class="alert alert-success" th:if="${message}" th:text="${message}"></div>
+  <div class="alert alert-danger" th:if="${errorMessage}" th:text="${errorMessage}"></div>
 
   <section class="content-band">
     <h2>테이블/뷰 추가</h2>
@@ -23,7 +24,6 @@
                   th:value="${dbObject.value()}"
                   th:data-owner="${dbObject.owner()}"
                   th:data-object-name="${dbObject.objectName()}"
-                  th:data-default-path="${dbObject.defaultOrdsPath()}"
                   th:text="${dbObject.label()}"></option>
         </select>
       </label>
@@ -37,7 +37,7 @@
       </label>
       <label>
         ORDS Path
-        <input class="form-control" name="ordsPath" placeholder="admin/cb_v_search_documents">
+        <input class="form-control" name="ordsPath" placeholder="cb-ords/cb-agent-security/vpd/documents" required>
       </label>
       <label>
         컬럼
@@ -69,7 +69,14 @@
           <td th:text="${object.objectId()}">1</td>
           <td th:text="${object.owner()}">ADMIN</td>
           <td th:text="${object.objectName()}">CB_V_SEARCH_DOCUMENTS</td>
-          <td><code th:text="${object.ordsPath()}">path</code></td>
+          <td>
+            <form method="post" action="/objects/ords-path" class="inline-form">
+              <input type="hidden" th:name="${_csrf.parameterName}" th:value="${_csrf.token}">
+              <input type="hidden" name="objectId" th:value="${object.objectId()}">
+              <input class="form-control form-control-sm" name="ordsPath" th:value="${object.ordsPath()}" required>
+              <button class="btn btn-sm btn-outline-primary" type="submit">저장</button>
+            </form>
+          </td>
           <td>
             <form method="post" action="/objects/disable" class="inline-form">
               <input type="hidden" th:name="${_csrf.parameterName}" th:value="${_csrf.token}">