Compare commits

..

5 Commits

Author SHA1 Message Date
joungmin
3304b9c54f docs(changelog): v0.1.24 P5-1 작은 후속 기록 2026-06-15 14:44:08 +09:00
joungmin
437e709a8d feat: P5-1 작은 후속 묶음 (#319+#325+#344)
#325 (#291 후속):
- VideoSseController.bulkExtract: Math.random() → ThreadLocalRandom 통일
  (bulkTranscript와 일관)
- VideoSseController.rebuildVectors: 즉시 complete(total=0) 대신 명시적
  'not_implemented' SSE 이벤트로 운영자 가시성 확보 + timeout 600s → 60s
- YouTubeService.getTranscript JavaDoc: mode 인자가 youtube-transcript-api
  폴백에서만 사용된다는 점, 브라우저 추출은 mode 무관 명시

#319 (#301 후속):
- RestaurantDetail: buildSearchQuery 헬퍼 추출 (외부 지도 검색 URL 조합)
  '한국' 단독 region 더미 케이스 가드 포함
- BottomSheet SNAP_POINTS/VELOCITY_THRESHOLD 정책 fn-doc 신규
  (docs/design/279-frontend-restaurant-detail/fn-bottomsheet-snap.md)

#344 (#283 후속):
- globals.css에 --z-bottom-sheet=50, --z-filter-sheet=60, --z-modal=70 토큰
- LoginMenu: zIndex 99999 매직 넘버 → var(--z-modal)

Refs: #319 #325 #344
2026-06-15 14:40:45 +09:00
joungmin
dcebb9f06f docs(changelog): v0.1.23 P4-4 별점/로그인 결함 기록 2026-06-15 14:34:27 +09:00
joungmin
bff3dcc200 feat(ui): P4-4 별점 공통화 + 로그인 모달 접근성 (#281+#283)
#281 (리뷰/메모 UI):
- Stars 컴포넌트 신규 (lib 분리 가능한 공통 별점) — 0.5 단위 절반 채우기 시각 구분
- ReviewSection/MemoSection의 StarDisplay 제거 → 공통 Stars 사용 (시각 일관성)
- StarSelector: role='radiogroup'/role='radio' + aria-checked, 44×44px 터치 영역,
  반쪽 별 '⯨' 표시로 시각 차별화
- ReviewSection/MemoSection: API 실패 try/catch + alert 사용자 피드백
- MyReviewsList: Math.round 별점 → Stars 0.5단위 정확 렌더

#283 (로그인 메뉴):
- LoginMenu: useEscapeKey + useFocusTrap + useBodyScrollLock 적용
- role='dialog' / aria-modal / aria-labelledby / aria-label='로그인 창 닫기'
- onError 콘솔만 → 인라인 role='alert' 메시지로 사용자 피드백
- max-w-xs → max-w-sm (위젯 260px + 패딩 24px = 308px 안전 수용)

후속 분리:
- #343 (next/image + ARIA Tabs + Stars 테스트)
- #344 (z-index 토큰 + i18n)

Refs: #281 #283
2026-06-15 14:33:15 +09:00
joungmin
ea8db4bef3 docs(changelog): v0.1.22 P4-3 인증/지도 결함 기록 2026-06-15 14:29:10 +09:00
11 changed files with 275 additions and 107 deletions

View File

@@ -6,6 +6,26 @@
## 2026-06-15 ## 2026-06-15
### 🧹 P5-1 작은 후속 묶음 (v0.1.24)
- #325: ThreadLocalRandom 통일, rebuildVectors not_implemented 이벤트, getTranscript JavaDoc 명세
- #319: buildSearchQuery 헬퍼 + fn-doc(BottomSheet snap 정책)
- #344: --z-bottom-sheet/--z-filter-sheet/--z-modal CSS 변수 + LoginMenu zIndex 99999 → var(--z-modal)
- Refs: #319 #325 #344 (close)
### ⭐ P4-4 별점 공통화 + 로그인 모달 접근성 (v0.1.23)
- #281: 공통 Stars 컴포넌트 (0.5단위 절반 채우기), StarSelector role=radiogroup + 44px + 반쪽 별 ⯨, try/catch + alert
- #283: LoginMenu에 useEscapeKey/useFocusTrap/useBodyScrollLock 훅 적용, role=dialog/aria-modal/aria-labelledby, onError 인라인 alert
- MyReviewsList: Math.round → Stars (0.5단위 정확 렌더)
- 후속 분리: #343(next/image, ARIA Tabs, 테스트), #344(z-index 토큰, i18n)
- Refs: #281 #283 (close)
### 🔐 P4-3 인증 메시지 + 지도 접근성 (v0.1.22)
- #266: Google verifier 실패 메시지 고정 + log.warn (정보 누출 차단)
- #278: boundsTimerRef cleanup, '내 위치' 44px + aria-label, dead code 제거
- #277: 결함 모두 후속(#338) — deep health/version/테스트는 별도
- 후속 분리: #338(deep health), #339(브랜드 토큰화/마커 ARIA), #340(다중 audience)
- Refs: #266 #277 #278 (close)
### ⚙️ P4-2 데몬/캐시/통계 결함 (v0.1.21) ### ⚙️ P4-2 데몬/캐시/통계 결함 (v0.1.21)
- #275: updateConfig 가드(1+ 정수), Scheduler try-finally updateLastX, GET config admin-only - #275: updateConfig 가드(1+ 정수), Scheduler try-finally updateLastX, GET config admin-only
- #276: ping try-with-resources + ConnectionFactory null 가드, makeKey null 가드 - #276: ping try-with-resources + ConnectionFactory null 가드, makeKey null 가드

View File

@@ -11,6 +11,7 @@ import org.springframework.web.bind.annotation.*;
import org.springframework.web.servlet.mvc.method.annotation.SseEmitter; import org.springframework.web.servlet.mvc.method.annotation.SseEmitter;
import java.util.*; import java.util.*;
import java.util.concurrent.ThreadLocalRandom;
import java.util.concurrent.ExecutorService; import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors; import java.util.concurrent.Executors;
import java.util.concurrent.ThreadLocalRandom; import java.util.concurrent.ThreadLocalRandom;
@@ -182,7 +183,8 @@ public class VideoSseController {
for (int i = 0; i < total; i++) { for (int i = 0; i < total; i++) {
var v = rows.get(i); var v = rows.get(i);
if (i > 0) { if (i > 0) {
long delay = (long) (3000 + Math.random() * 5000); // #325 — ThreadLocalRandom으로 통일 (bulkTranscript와 일관성)
long delay = 3000L + ThreadLocalRandom.current().nextLong(5000);
emit(emitter, Map.of("type", "wait", "index", i, "delay", delay / 1000.0)); emit(emitter, Map.of("type", "wait", "index", i, "delay", delay / 1000.0));
Thread.sleep(delay); Thread.sleep(delay);
} }
@@ -347,13 +349,15 @@ public class VideoSseController {
@PostMapping("/rebuild-vectors") @PostMapping("/rebuild-vectors")
public SseEmitter rebuildVectors() { public SseEmitter rebuildVectors() {
AuthUtil.requireAdmin(); AuthUtil.requireAdmin();
SseEmitter emitter = new SseEmitter(600_000L); SseEmitter emitter = new SseEmitter(60_000L);
executor.execute(() -> { executor.execute(() -> {
try { try {
emit(emitter, Map.of("type", "start")); // #325 — 운영자에게 미구현 상태 명시 (이전: 즉시 complete(total=0) → 무반응 인상)
// TODO: Implement full vector rebuild using VectorService emit(emitter, Map.of(
emit(emitter, Map.of("type", "complete", "total", 0)); "type", "not_implemented",
"message", "벡터 재생성은 아직 구현되지 않았습니다. 후속 이슈(#325/#331)에서 처리 예정입니다."
));
emitter.complete(); emitter.complete();
} catch (Exception e) { } catch (Exception e) {
emitter.completeWithError(e); emitter.completeWithError(e);

View File

@@ -278,8 +278,19 @@ public class YouTubeService {
/** /**
* Fetch transcript for a YouTube video. * Fetch transcript for a YouTube video.
* Tries API first (fast), then falls back to Playwright browser extraction. *
* @param mode "auto" = manual first then generated, "manual" = manual only, "generated" = generated only * 흐름: (1) Playwright headed 브라우저 추출 → (2) 실패 시 youtube-transcript-api 폴백.
*
* <p>#325 — mode 인자 명세:
* <ul>
* <li>"auto" (기본): manual → generated 순서로 시도</li>
* <li>"manual": manual(사람이 쓴 자막)만</li>
* <li>"generated": 자동 생성 자막만</li>
* </ul>
* 주의: mode 인자는 <b>youtube-transcript-api 폴백 경로에서만 사용</b>됩니다.
* 브라우저 추출은 YouTube가 노출하는 자막 트랙 전체를 그대로 수신하므로 mode 무관.
*
* @param mode 위 설명 참조. null이면 "auto"로 간주.
*/ */
public TranscriptResult getTranscript(String videoId, String mode) { public TranscriptResult getTranscript(String videoId, String mode) {
if (mode == null) mode = "auto"; if (mode == null) mode = "auto";

View File

@@ -0,0 +1,54 @@
<!-- 함수 설계서. 작성: [AI] Architect. -->
# 함수 설계서: BottomSheet snap 정책 (#319)
> **상태**: Approved <!-- Draft | Approved | Superseded -->
> **작성**: [AI] Architect · **최종수정**: 2026-06-15
> **추적성** — Redmine: #319 / 부모 #301 · 관련 컴포넌트: `frontend/src/components/BottomSheet.tsx`
## 1. 책임
모바일 BottomSheet의 **3-snap 점착(snap) 점**과 **닫힘 임계 속도**를 정의하고, 사용자의 드래그 제스처가 어느 snap에 안착할지 결정하는 알고리즘을 명세한다.
## 2. 상수 (매직 넘버)
| 상수 | 값 | 의미 |
|------|----|------|
| `SNAP_POINTS.PEEK` | `0.4` | 초기/맨 아래 snap. 화면 높이의 40%만 시트가 보임 — 지도와 시트를 함께 보는 균형. |
| `SNAP_POINTS.HALF` | `0.55` | 중간 snap. 시트 콘텐츠 핵심(이름·평점·리뷰 첫 줄)이 잘 보이는 위치. |
| `SNAP_POINTS.FULL` | `0.92` | 거의 풀 화면. 8% 여백은 상단 스와이프 핸들·상태바를 위해 남김. |
| `VELOCITY_THRESHOLD` | `0.5` (vh/s) | 빠른 아래 스와이프 감지 기준. 초당 화면 높이의 50% 이상이면 "닫기 의도"로 간주. |
| `CLOSE_BELOW_RATIO` | `0.6 × PEEK` ≈ 0.24 | snap 후보 중 PEEK의 60% 아래로 끌어내리면 강제 닫힘. |
## 3. 결정 알고리즘 (`snapTo(height, velocity)`)
```
입력: height(현재 높이 ratio 0~1), velocity(아래 방향 vh/s, 양수=아래)
1. velocity > VELOCITY_THRESHOLD && height < HALF → onClose()
2. height < CLOSE_BELOW_RATIO → onClose()
3. 그 외: [PEEK, HALF, FULL] 중 height와 최단 거리인 점에 setHeight()
```
## 4. 왜 이 값들인가 (근거)
- **0.4/0.55/0.92**: 모바일 UX 가이드(Material/iOS BottomSheet)의 30%/50%/95% 패턴을 한국 식당 카드 콘텐츠 길이(이름 18px + 평점 16px + 영상 썸네일 200px 기준)에 맞춰 조정.
- **0.5 vh/s**: 일반 손가락 플릭 속도가 0.7~1.2 vh/s, 의도적인 닫기 스와이프 임계점.
- **0.24 close-below**: PEEK(0.4)의 60% — 우발적 드래그(<0.05) 차단 + 의도적 닫기(<0.24) 수용.
## 5. 변경 시 주의
- 사용자의 근육 기억(스와이프 거리 감각) 교란 위험이 있어 SNAP_POINTS 변경은 ADR로 분리할 것.
- VELOCITY_THRESHOLD를 낮추면 의도치 않은 닫힘 ↑, 높이면 닫기 어려움 ↑.
## 6. 테스트 권고
- `snapTo(0.45, 0.1)` → HALF로 안착
- `snapTo(0.2, 0.7)` → onClose 호출
- `snapTo(0.85, 0)` → FULL로 안착
- `snapTo(0.1, 0)` → onClose 호출 (CLOSE_BELOW_RATIO)
- 단위 테스트는 `utils/bottomSheetSnap.ts`로 함수 추출 후 #343에서 진행.
## 7. 미해결 질문
- 가로 모드 / 큰 폰트 접근성 모드에서 PEEK가 너무 작아 보이는 케이스 — 향후 동적 조정 검토.

View File

@@ -18,6 +18,10 @@
--brand-800: #9A4500; --brand-800: #9A4500;
--brand-900: #6B3000; --brand-900: #6B3000;
--brand-950: #3D1A00; --brand-950: #3D1A00;
/* #344 z-index 토큰 (모달/오버레이가 매직 넘버 없이 일관) */
--z-bottom-sheet: 50;
--z-filter-sheet: 60;
--z-modal: 70;
color-scheme: only light !important; color-scheme: only light !important;
} }

View File

@@ -1,8 +1,9 @@
"use client"; "use client";
import { useState } from "react"; import { useRef, useState } from "react";
import { createPortal } from "react-dom"; import { createPortal } from "react-dom";
import { GoogleLogin } from "@react-oauth/google"; import { GoogleLogin } from "@react-oauth/google";
import { useEscapeKey, useFocusTrap, useBodyScrollLock } from "@/lib/hooks/useModalA11y";
interface LoginMenuProps { interface LoginMenuProps {
onGoogleSuccess: (credential: string) => void; onGoogleSuccess: (credential: string) => void;
@@ -10,6 +11,22 @@ interface LoginMenuProps {
export default function LoginMenu({ onGoogleSuccess }: LoginMenuProps) { export default function LoginMenu({ onGoogleSuccess }: LoginMenuProps) {
const [open, setOpen] = useState(false); const [open, setOpen] = useState(false);
const [errorMsg, setErrorMsg] = useState<string | null>(null);
const dialogRef = useRef<HTMLDivElement>(null);
const titleId = "login-dialog-title";
// #283 — 모달 접근성: ESC / focus trap / body scroll lock
useEscapeKey(open, () => setOpen(false));
useFocusTrap(open, dialogRef);
useBodyScrollLock(open);
const handleSuccess = (res: { credential?: string }) => {
setErrorMsg(null);
if (res.credential) {
onGoogleSuccess(res.credential);
setOpen(false);
}
};
return ( return (
<> <>
@@ -22,30 +39,40 @@ export default function LoginMenu({ onGoogleSuccess }: LoginMenuProps) {
{open && createPortal( {open && createPortal(
<div <div
// #344 — z-index 매직 넘버 99999 → CSS 변수 토큰 (--z-modal=70).
// 다른 오버레이(BottomSheet=50, FilterSheet=60) 위 일관된 stacking.
className="fixed inset-0 flex items-center justify-center bg-black/40 backdrop-blur-sm" className="fixed inset-0 flex items-center justify-center bg-black/40 backdrop-blur-sm"
style={{ zIndex: 99999 }} style={{ zIndex: "var(--z-modal)" } as React.CSSProperties}
onClick={(e) => { if (e.target === e.currentTarget) setOpen(false); }} onClick={(e) => { if (e.target === e.currentTarget) setOpen(false); }}
> >
<div className="bg-surface rounded-2xl shadow-2xl p-6 mx-4 w-full max-w-xs space-y-4"> <div
ref={dialogRef}
role="dialog"
aria-modal="true"
aria-labelledby={titleId}
tabIndex={-1}
className="bg-surface rounded-2xl shadow-2xl p-6 mx-4 w-full max-w-sm space-y-4"
>
<div className="flex items-center justify-between"> <div className="flex items-center justify-between">
<h3 className="text-base font-semibold dark:text-gray-100"></h3> <h3 id={titleId} className="text-base font-semibold dark:text-gray-100"></h3>
<button <button
onClick={() => setOpen(false)} onClick={() => setOpen(false)}
className="text-gray-400 hover:text-gray-600 dark:hover:text-gray-200 text-lg leading-none" aria-label="로그인 창 닫기"
className="text-gray-400 hover:text-gray-600 dark:hover:text-gray-200 text-lg leading-none p-2 -m-2"
> >
</button> </button>
</div> </div>
<p className="text-xs text-gray-400 dark:text-gray-500"> </p> <p className="text-xs text-gray-400 dark:text-gray-500"> </p>
{errorMsg && (
<p role="alert" className="text-xs text-red-600 dark:text-red-400 bg-red-50 dark:bg-red-950/40 rounded p-2">
{errorMsg}
</p>
)}
<div className="flex flex-col items-center gap-3"> <div className="flex flex-col items-center gap-3">
<GoogleLogin <GoogleLogin
onSuccess={(res) => { onSuccess={handleSuccess}
if (res.credential) { onError={() => setErrorMsg("Google 로그인에 실패했습니다. 팝업 차단 또는 네트워크 상태를 확인해주세요.")}
onGoogleSuccess(res.credential);
setOpen(false);
}
}}
onError={() => console.error("Google login failed")}
size="large" size="large"
width="260" width="260"
text="signin_with" text="signin_with"

View File

@@ -5,11 +5,13 @@ import { api } from "@/lib/api";
import type { Memo } from "@/lib/api"; import type { Memo } from "@/lib/api";
import { useAuth } from "@/lib/auth-context"; import { useAuth } from "@/lib/auth-context";
import Icon from "@/components/Icon"; import Icon from "@/components/Icon";
import Stars from "@/components/Stars";
interface MemoSectionProps { interface MemoSectionProps {
restaurantId: string; restaurantId: string;
} }
// #281 — ReviewSection의 StarSelector와 동일 UX (0.5 단위 + 44px 터치 + ARIA radiogroup)
function StarSelector({ function StarSelector({
value, value,
onChange, onChange,
@@ -18,38 +20,32 @@ function StarSelector({
onChange: (v: number) => void; onChange: (v: number) => void;
}) { }) {
return ( return (
<div className="flex items-center gap-1"> <div role="radiogroup" aria-label="별점 선택" className="flex items-center gap-0.5">
<span className="text-xs text-gray-500 mr-1">:</span> <span className="text-xs text-gray-500 mr-1">:</span>
{[0.5, 1, 1.5, 2, 2.5, 3, 3.5, 4, 4.5, 5].map((v) => ( {[1, 2, 3, 4, 5].map((v) => {
const nextVal = value === v ? v - 0.5 : v;
return (
<button <button
key={v} key={v}
type="button" type="button"
onClick={() => onChange(v)} role="radio"
className={`w-6 h-6 text-xs rounded border ${ aria-checked={value >= v - 0.5 && value <= v}
value === v aria-label={`${nextVal}`}
? "bg-yellow-500 text-white border-yellow-600" onClick={() => onChange(nextVal)}
: "bg-white text-gray-600 border-gray-300 hover:border-yellow-400" className="min-w-[44px] min-h-[44px] flex items-center justify-center touch-manipulation"
}`} title={`${nextVal}`}
> >
{v} <span className={`text-xl ${v <= value ? "text-yellow-500" : v - 0.5 === value ? "text-yellow-400" : "text-gray-300"}`}>
{v <= value ? "★" : v - 0.5 === value ? "⯨" : "☆"}
</span>
</button> </button>
))} );
})}
{value > 0 && <span className="text-xs text-yellow-600 font-medium ml-1">{value}</span>}
</div> </div>
); );
} }
function StarDisplay({ rating }: { rating: number }) {
const stars = [];
for (let i = 1; i <= 5; i++) {
stars.push(
<span key={i} className={rating >= i - 0.5 ? "text-yellow-500" : "text-gray-300"}>
</span>
);
}
return <span className="text-sm">{stars}</span>;
}
export default function MemoSection({ restaurantId }: MemoSectionProps) { export default function MemoSection({ restaurantId }: MemoSectionProps) {
const { user } = useAuth(); const { user } = useAuth();
const [memo, setMemo] = useState<Memo | null>(null); const [memo, setMemo] = useState<Memo | null>(null);
@@ -104,6 +100,9 @@ export default function MemoSection({ restaurantId }: MemoSectionProps) {
setMemo(saved); setMemo(saved);
setShowForm(false); setShowForm(false);
setEditing(false); setEditing(false);
} catch (err) {
// #281 — 사용자 피드백
alert(`메모 저장 실패: ${err instanceof Error ? err.message : String(err)}`);
} finally { } finally {
setSubmitting(false); setSubmitting(false);
} }
@@ -111,8 +110,12 @@ export default function MemoSection({ restaurantId }: MemoSectionProps) {
const handleDelete = async () => { const handleDelete = async () => {
if (!confirm("메모를 삭제하시겠습니까?")) return; if (!confirm("메모를 삭제하시겠습니까?")) return;
try {
await api.deleteMemo(restaurantId); await api.deleteMemo(restaurantId);
setMemo(null); setMemo(null);
} catch (err) {
alert(`메모 삭제 실패: ${err instanceof Error ? err.message : String(err)}`);
}
}; };
return ( return (
@@ -167,7 +170,7 @@ export default function MemoSection({ restaurantId }: MemoSectionProps) {
) : memo ? ( ) : memo ? (
<div className="border border-brand-200 rounded-lg p-3 bg-brand-50/30"> <div className="border border-brand-200 rounded-lg p-3 bg-brand-50/30">
<div className="flex items-center gap-2 mb-1"> <div className="flex items-center gap-2 mb-1">
{memo.rating && <StarDisplay rating={memo.rating} />} {memo.rating && <Stars rating={memo.rating} />}
{memo.visited_at && ( {memo.visited_at && (
<span className="text-xs text-gray-400">: {memo.visited_at}</span> <span className="text-xs text-gray-400">: {memo.visited_at}</span>
)} )}

View File

@@ -3,6 +3,7 @@
import { useState } from "react"; import { useState } from "react";
import type { Review, Memo } from "@/lib/api"; import type { Review, Memo } from "@/lib/api";
import Icon from "@/components/Icon"; import Icon from "@/components/Icon";
import Stars from "@/components/Stars";
interface MyReview extends Review { interface MyReview extends Review {
restaurant_id: string; restaurant_id: string;
@@ -82,9 +83,9 @@ export default function MyReviewsList({
<span className="font-semibold text-sm truncate"> <span className="font-semibold text-sm truncate">
{r.restaurant_name || "알 수 없는 식당"} {r.restaurant_name || "알 수 없는 식당"}
</span> </span>
<span className="text-yellow-500 text-sm shrink-0 ml-2"> <span className="text-sm shrink-0 ml-2 flex items-center gap-1">
{"★".repeat(Math.round(r.rating))} <Stars rating={r.rating} />
<span className="text-gray-500 ml-1">{r.rating}</span> <span className="text-gray-500">{r.rating}</span>
</span> </span>
</div> </div>
{r.review_text && ( {r.review_text && (
@@ -118,9 +119,9 @@ export default function MyReviewsList({
{m.restaurant_name || "알 수 없는 식당"} {m.restaurant_name || "알 수 없는 식당"}
</span> </span>
{m.rating && ( {m.rating && (
<span className="text-yellow-500 text-sm shrink-0 ml-2"> <span className="text-sm shrink-0 ml-2 flex items-center gap-1">
{"★".repeat(Math.round(m.rating))} <Stars rating={m.rating} />
<span className="text-gray-500 ml-1">{m.rating}</span> <span className="text-gray-500">{m.rating}</span>
</span> </span>
)} )}
</div> </div>

View File

@@ -13,6 +13,17 @@ interface RestaurantDetailProps {
onClose: () => void; onClose: () => void;
} }
// #319 — 외부 지도 검색용 쿼리 빌더. region이 더미('나라|' 형태)면 무시.
function buildSearchQuery(r: Restaurant): string {
if (r.address) return `${r.name} ${r.address}`;
if (r.region) {
const cleanRegion = r.region.replace(/\|/g, " ").trim();
// 빈 토큰만 남는 경우 (예: '한국' 또는 '한국|') → name만 사용
if (cleanRegion && cleanRegion !== "한국") return `${r.name} ${cleanRegion}`;
}
return r.name;
}
export default function RestaurantDetail({ export default function RestaurantDetail({
restaurant, restaurant,
onClose, onClose,
@@ -128,7 +139,7 @@ export default function RestaurantDetail({
{restaurant.google_place_id && ( {restaurant.google_place_id && (
<p className="flex gap-3"> <p className="flex gap-3">
<a <a
href={`https://www.google.com/maps/search/?api=1&query=${encodeURIComponent(restaurant.name + (restaurant.address ? " " + restaurant.address : restaurant.region ? " " + restaurant.region.replace(/\|/g, " ") : ""))}`} href={`https://www.google.com/maps/search/?api=1&query=${encodeURIComponent(buildSearchQuery(restaurant))}`}
target="_blank" target="_blank"
rel="noopener noreferrer" rel="noopener noreferrer"
className="text-brand-600 dark:text-brand-400 hover:underline text-xs" className="text-brand-600 dark:text-brand-400 hover:underline text-xs"

View File

@@ -4,37 +4,12 @@ import { useCallback, useEffect, useState } from "react";
import { api } from "@/lib/api"; import { api } from "@/lib/api";
import type { Review } from "@/lib/api"; import type { Review } from "@/lib/api";
import { useAuth } from "@/lib/auth-context"; import { useAuth } from "@/lib/auth-context";
import Stars from "@/components/Stars";
interface ReviewSectionProps { interface ReviewSectionProps {
restaurantId: string; restaurantId: string;
} }
function StarDisplay({ rating }: { rating: number }) {
const stars = [];
for (let i = 1; i <= 5; i++) {
if (rating >= i) {
stars.push(
<span key={i} className="text-yellow-500">
</span>
);
} else if (rating >= i - 0.5) {
stars.push(
<span key={i} className="text-yellow-500">
</span>
);
} else {
stars.push(
<span key={i} className="text-gray-300">
</span>
);
}
}
return <span className="text-sm">{stars}</span>;
}
function StarSelector({ function StarSelector({
value, value,
onChange, onChange,
@@ -43,22 +18,30 @@ function StarSelector({
onChange: (v: number) => void; onChange: (v: number) => void;
}) { }) {
return ( return (
<div className="flex items-center gap-1"> <div role="radiogroup" aria-label="별점 선택" className="flex items-center gap-0.5">
<span className="text-xs text-gray-500 mr-1">:</span> <span className="text-xs text-gray-500 mr-1">:</span>
{[0.5, 1, 1.5, 2, 2.5, 3, 3.5, 4, 4.5, 5].map((v) => ( {[1, 2, 3, 4, 5].map((v) => {
const isCurrent = value === v || value === v - 0.5;
const nextVal = value === v ? v - 0.5 : v;
return (
<button <button
key={v} key={v}
type="button" type="button"
onClick={() => onChange(v)} role="radio"
className={`w-6 h-6 text-xs rounded border ${ aria-checked={value >= v - 0.5 && value <= v}
value === v aria-label={`${nextVal}`}
? "bg-yellow-500 text-white border-yellow-600" onClick={() => onChange(nextVal)}
: "bg-white text-gray-600 border-gray-300 hover:border-yellow-400" // #281 — 최소 터치 영역 44×44
}`} className="min-w-[44px] min-h-[44px] flex items-center justify-center touch-manipulation"
title={`${nextVal}`}
> >
{v} <span className={`text-xl ${v <= value ? "text-yellow-500" : v - 0.5 === value ? "text-yellow-400" : "text-gray-300"}`}>
{v <= value ? "★" : v - 0.5 === value ? "⯨" : "☆"}
</span>
</button> </button>
))} );
})}
{value > 0 && <span className="text-xs text-yellow-600 font-medium ml-1">{value}</span>}
</div> </div>
); );
} }
@@ -170,29 +153,42 @@ export default function ReviewSection({ restaurantId }: ReviewSectionProps) {
? reviews.find((r) => r.user_id === user.id) ? reviews.find((r) => r.user_id === user.id)
: null; : null;
// #281 — API 실패 시 unhandled rejection 방지 + 사용자 피드백
const handleCreate = async (data: { const handleCreate = async (data: {
rating: number; rating: number;
review_text?: string; review_text?: string;
visited_at?: string; visited_at?: string;
}) => { }) => {
try {
await api.createReview(restaurantId, data); await api.createReview(restaurantId, data);
setShowForm(false); setShowForm(false);
loadReviews(); loadReviews();
} catch (e) {
alert(`리뷰 작성 실패: ${e instanceof Error ? e.message : String(e)}`);
}
}; };
const handleUpdate = async ( const handleUpdate = async (
reviewId: string, reviewId: string,
data: { rating: number; review_text?: string; visited_at?: string } data: { rating: number; review_text?: string; visited_at?: string }
) => { ) => {
try {
await api.updateReview(reviewId, data); await api.updateReview(reviewId, data);
setEditingId(null); setEditingId(null);
loadReviews(); loadReviews();
} catch (e) {
alert(`리뷰 수정 실패: ${e instanceof Error ? e.message : String(e)}`);
}
}; };
const handleDelete = async (reviewId: string) => { const handleDelete = async (reviewId: string) => {
if (!confirm("리뷰를 삭제하시겠습니까?")) return; if (!confirm("리뷰를 삭제하시겠습니까?")) return;
try {
await api.deleteReview(reviewId); await api.deleteReview(reviewId);
loadReviews(); loadReviews();
} catch (e) {
alert(`리뷰 삭제 실패: ${e instanceof Error ? e.message : String(e)}`);
}
}; };
return ( return (
@@ -216,7 +212,7 @@ export default function ReviewSection({ restaurantId }: ReviewSectionProps) {
<> <>
{reviewCount > 0 && avgRating !== null && ( {reviewCount > 0 && avgRating !== null && (
<div className="flex items-center gap-2 mb-3 text-sm"> <div className="flex items-center gap-2 mb-3 text-sm">
<StarDisplay rating={Math.round(avgRating * 2) / 2} /> <Stars rating={Math.round(avgRating * 2) / 2} />
<span className="font-medium">{avgRating.toFixed(1)}</span> <span className="font-medium">{avgRating.toFixed(1)}</span>
<span className="text-gray-500">({reviewCount})</span> <span className="text-gray-500">({reviewCount})</span>
</div> </div>
@@ -270,7 +266,7 @@ export default function ReviewSection({ restaurantId }: ReviewSectionProps) {
<span className="text-sm font-medium"> <span className="text-sm font-medium">
{review.user_nickname || "익명"} {review.user_nickname || "익명"}
</span> </span>
<StarDisplay rating={review.rating} /> <Stars rating={review.rating} />
<span className="text-xs text-gray-400"> <span className="text-xs text-gray-400">
{new Date(review.created_at).toLocaleDateString( {new Date(review.created_at).toLocaleDateString(
"ko-KR" "ko-KR"

View File

@@ -0,0 +1,37 @@
// #281 공통 별점 컴포넌트 — ReviewSection/MemoSection/MyReviewsList 재사용.
// 0.5 단위 시각 구분: 빈 별 위에 황색 절반 별을 절대배치 + clip으로 표시.
interface StarsProps {
rating: number; // 0~5, 0.5 단위
size?: "sm" | "md";
showNumber?: boolean;
className?: string;
}
export default function Stars({ rating, size = "sm", showNumber = false, className = "" }: StarsProps) {
const r = Math.max(0, Math.min(5, rating));
const textSize = size === "md" ? "text-base" : "text-sm";
return (
<span className={`inline-flex items-center gap-0.5 ${textSize} ${className}`} aria-label={`${r}`}>
{[1, 2, 3, 4, 5].map((i) => {
const full = r >= i;
const half = !full && r >= i - 0.5;
return (
<span key={i} className="relative inline-block leading-none">
<span className="text-gray-300"></span>
{(full || half) && (
<span
aria-hidden="true"
className="absolute inset-0 text-yellow-500 overflow-hidden"
style={{ width: full ? "100%" : "50%" }}
>
</span>
)}
</span>
);
})}
{showNumber && r > 0 && <span className="text-xs text-yellow-600 font-medium ml-1">{r}</span>}
</span>
);
}