feat(ui): P4-4 별점 공통화 + 로그인 모달 접근성 (#281+#283)

#281 (리뷰/메모 UI): - Stars 컴포넌트 신규 (lib 분리 가능한 공통 별점) — 0.5 단위 절반 채우기 시각 구분 - ReviewSection/MemoSection의 StarDisplay 제거 → 공통 Stars 사용 (시각 일관성) - StarSelector: role='radiogroup'/role='radio' + aria-checked, 44×44px 터치 영역, 반쪽 별 '⯨' 표시로 시각 차별화 - ReviewSection/MemoSection: API 실패 try/catch + alert 사용자 피드백 - MyReviewsList: Math.round 별점 → Stars 0.5단위 정확 렌더 #283 (로그인 메뉴): - LoginMenu: useEscapeKey + useFocusTrap + useBodyScrollLock 적용 - role='dialog' / aria-modal / aria-labelledby / aria-label='로그인 창 닫기' - onError 콘솔만 → 인라인 role='alert' 메시지로 사용자 피드백 - max-w-xs → max-w-sm (위젯 260px + 패딩 24px = 308px 안전 수용) 후속 분리: - #343 (next/image + ARIA Tabs + Stars 테스트) - #344 (z-index 토큰 + i18n) Refs: #281 #283
2026-06-15 14:33:15 +09:00
parent ea8db4bef3
commit bff3dcc200
5 changed files with 160 additions and 98 deletions
--- a/frontend/src/components/LoginMenu.tsx
+++ b/frontend/src/components/LoginMenu.tsx
@@ -1,8 +1,9 @@
 "use client";

-import { useState } from "react";
+import { useRef, useState } from "react";
 import { createPortal } from "react-dom";
 import { GoogleLogin } from "@react-oauth/google";
+import { useEscapeKey, useFocusTrap, useBodyScrollLock } from "@/lib/hooks/useModalA11y";

 interface LoginMenuProps {
  onGoogleSuccess: (credential: string) => void;
@@ -10,6 +11,22 @@ interface LoginMenuProps {

 export default function LoginMenu({ onGoogleSuccess }: LoginMenuProps) {
  const [open, setOpen] = useState(false);
+  const [errorMsg, setErrorMsg] = useState<string | null>(null);
+  const dialogRef = useRef<HTMLDivElement>(null);
+  const titleId = "login-dialog-title";
+
+  // #283 — 모달 접근성: ESC / focus trap / body scroll lock
+  useEscapeKey(open, () => setOpen(false));
+  useFocusTrap(open, dialogRef);
+  useBodyScrollLock(open);
+
+  const handleSuccess = (res: { credential?: string }) => {
+    setErrorMsg(null);
+    if (res.credential) {
+      onGoogleSuccess(res.credential);
+      setOpen(false);
+    }
+  };

  return (
    <>
@@ -26,26 +43,34 @@ export default function LoginMenu({ onGoogleSuccess }: LoginMenuProps) {
          style={{ zIndex: 99999 }}
          onClick={(e) => { if (e.target === e.currentTarget) setOpen(false); }}
        >
-          <div className="bg-surface rounded-2xl shadow-2xl p-6 mx-4 w-full max-w-xs space-y-4">
+          <div
+            ref={dialogRef}
+            role="dialog"
+            aria-modal="true"
+            aria-labelledby={titleId}
+            tabIndex={-1}
+            className="bg-surface rounded-2xl shadow-2xl p-6 mx-4 w-full max-w-sm space-y-4"
+          >
            <div className="flex items-center justify-between">
-              <h3 className="text-base font-semibold dark:text-gray-100">로그인</h3>
+              <h3 id={titleId} className="text-base font-semibold dark:text-gray-100">로그인</h3>
              <button
                onClick={() => setOpen(false)}
-                className="text-gray-400 hover:text-gray-600 dark:hover:text-gray-200 text-lg leading-none"
+                aria-label="로그인 창 닫기"
+                className="text-gray-400 hover:text-gray-600 dark:hover:text-gray-200 text-lg leading-none p-2 -m-2"
              >
                ✕
              </button>
            </div>
            <p className="text-xs text-gray-400 dark:text-gray-500">소셜 계정으로 간편 로그인</p>
+            {errorMsg && (
+              <p role="alert" className="text-xs text-red-600 dark:text-red-400 bg-red-50 dark:bg-red-950/40 rounded p-2">
+                {errorMsg}
+              </p>
+            )}
            <div className="flex flex-col items-center gap-3">
              <GoogleLogin
-                onSuccess={(res) => {
-                  if (res.credential) {
-                    onGoogleSuccess(res.credential);
-                    setOpen(false);
-                  }
-                }}
-                onError={() => console.error("Google login failed")}
+                onSuccess={handleSuccess}
+                onError={() => setErrorMsg("Google 로그인에 실패했습니다. 팝업 차단 또는 네트워크 상태를 확인해주세요.")}
                size="large"
                width="260"
                text="signin_with"
--- a/frontend/src/components/MemoSection.tsx
+++ b/frontend/src/components/MemoSection.tsx
@@ -5,11 +5,13 @@ import { api } from "@/lib/api";
 import type { Memo } from "@/lib/api";
 import { useAuth } from "@/lib/auth-context";
 import Icon from "@/components/Icon";
+import Stars from "@/components/Stars";

 interface MemoSectionProps {
  restaurantId: string;
 }

+// #281 — ReviewSection의 StarSelector와 동일 UX (0.5 단위 + 44px 터치 + ARIA radiogroup)
 function StarSelector({
  value,
  onChange,
@@ -18,38 +20,32 @@ function StarSelector({
  onChange: (v: number) => void;
 }) {
  return (
-    <div className="flex items-center gap-1">
+    <div role="radiogroup" aria-label="별점 선택" className="flex items-center gap-0.5">
      <span className="text-xs text-gray-500 mr-1">별점:</span>
-      {[0.5, 1, 1.5, 2, 2.5, 3, 3.5, 4, 4.5, 5].map((v) => (
+      {[1, 2, 3, 4, 5].map((v) => {
+        const nextVal = value === v ? v - 0.5 : v;
+        return (
          <button
            key={v}
            type="button"
-          onClick={() => onChange(v)}
-          className={`w-6 h-6 text-xs rounded border ${
-            value === v
-              ? "bg-yellow-500 text-white border-yellow-600"
-              : "bg-white text-gray-600 border-gray-300 hover:border-yellow-400"
-          }`}
+            role="radio"
+            aria-checked={value >= v - 0.5 && value <= v}
+            aria-label={`${nextVal}점`}
+            onClick={() => onChange(nextVal)}
+            className="min-w-[44px] min-h-[44px] flex items-center justify-center touch-manipulation"
+            title={`${nextVal}점`}
          >
-          {v}
+            <span className={`text-xl ${v <= value ? "text-yellow-500" : v - 0.5 === value ? "text-yellow-400" : "text-gray-300"}`}>
+              {v <= value ? "★" : v - 0.5 === value ? "⯨" : "☆"}
+            </span>
          </button>
-      ))}
+        );
+      })}
+      {value > 0 && <span className="text-xs text-yellow-600 font-medium ml-1">{value}</span>}
    </div>
  );
 }

-function StarDisplay({ rating }: { rating: number }) {
-  const stars = [];
-  for (let i = 1; i <= 5; i++) {
-    stars.push(
-      <span key={i} className={rating >= i - 0.5 ? "text-yellow-500" : "text-gray-300"}>
-        ★
-      </span>
-    );
-  }
-  return <span className="text-sm">{stars}</span>;
-}
-
 export default function MemoSection({ restaurantId }: MemoSectionProps) {
  const { user } = useAuth();
  const [memo, setMemo] = useState<Memo | null>(null);
@@ -104,6 +100,9 @@ export default function MemoSection({ restaurantId }: MemoSectionProps) {
      setMemo(saved);
      setShowForm(false);
      setEditing(false);
+    } catch (err) {
+      // #281 — 사용자 피드백
+      alert(`메모 저장 실패: ${err instanceof Error ? err.message : String(err)}`);
    } finally {
      setSubmitting(false);
    }
@@ -111,8 +110,12 @@ export default function MemoSection({ restaurantId }: MemoSectionProps) {

  const handleDelete = async () => {
    if (!confirm("메모를 삭제하시겠습니까?")) return;
+    try {
      await api.deleteMemo(restaurantId);
      setMemo(null);
+    } catch (err) {
+      alert(`메모 삭제 실패: ${err instanceof Error ? err.message : String(err)}`);
+    }
  };

  return (
@@ -167,7 +170,7 @@ export default function MemoSection({ restaurantId }: MemoSectionProps) {
      ) : memo ? (
        <div className="border border-brand-200 rounded-lg p-3 bg-brand-50/30">
          <div className="flex items-center gap-2 mb-1">
-            {memo.rating && <StarDisplay rating={memo.rating} />}
+            {memo.rating && <Stars rating={memo.rating} />}
            {memo.visited_at && (
              <span className="text-xs text-gray-400">방문일: {memo.visited_at}</span>
            )}
--- a/frontend/src/components/MyReviewsList.tsx
+++ b/frontend/src/components/MyReviewsList.tsx
@@ -3,6 +3,7 @@
 import { useState } from "react";
 import type { Review, Memo } from "@/lib/api";
 import Icon from "@/components/Icon";
+import Stars from "@/components/Stars";

 interface MyReview extends Review {
  restaurant_id: string;
@@ -82,9 +83,9 @@ export default function MyReviewsList({
                  <span className="font-semibold text-sm truncate">
                    {r.restaurant_name || "알 수 없는 식당"}
                  </span>
-                  <span className="text-yellow-500 text-sm shrink-0 ml-2">
-                    {"★".repeat(Math.round(r.rating))}
-                    <span className="text-gray-500 ml-1">{r.rating}</span>
+                  <span className="text-sm shrink-0 ml-2 flex items-center gap-1">
+                    <Stars rating={r.rating} />
+                    <span className="text-gray-500">{r.rating}</span>
                  </span>
                </div>
                {r.review_text && (
@@ -118,9 +119,9 @@ export default function MyReviewsList({
                    {m.restaurant_name || "알 수 없는 식당"}
                  </span>
                  {m.rating && (
-                    <span className="text-yellow-500 text-sm shrink-0 ml-2">
-                      {"★".repeat(Math.round(m.rating))}
-                      <span className="text-gray-500 ml-1">{m.rating}</span>
+                    <span className="text-sm shrink-0 ml-2 flex items-center gap-1">
+                      <Stars rating={m.rating} />
+                      <span className="text-gray-500">{m.rating}</span>
                    </span>
                  )}
                </div>
--- a/frontend/src/components/ReviewSection.tsx
+++ b/frontend/src/components/ReviewSection.tsx
@@ -4,37 +4,12 @@ import { useCallback, useEffect, useState } from "react";
 import { api } from "@/lib/api";
 import type { Review } from "@/lib/api";
 import { useAuth } from "@/lib/auth-context";
+import Stars from "@/components/Stars";

 interface ReviewSectionProps {
  restaurantId: string;
 }

-function StarDisplay({ rating }: { rating: number }) {
-  const stars = [];
-  for (let i = 1; i <= 5; i++) {
-    if (rating >= i) {
-      stars.push(
-        <span key={i} className="text-yellow-500">
-          ★
-        </span>
-      );
-    } else if (rating >= i - 0.5) {
-      stars.push(
-        <span key={i} className="text-yellow-500">
-          ★
-        </span>
-      );
-    } else {
-      stars.push(
-        <span key={i} className="text-gray-300">
-          ★
-        </span>
-      );
-    }
-  }
-  return <span className="text-sm">{stars}</span>;
-}
-
 function StarSelector({
  value,
  onChange,
@@ -43,22 +18,30 @@ function StarSelector({
  onChange: (v: number) => void;
 }) {
  return (
-    <div className="flex items-center gap-1">
+    <div role="radiogroup" aria-label="별점 선택" className="flex items-center gap-0.5">
      <span className="text-xs text-gray-500 mr-1">별점:</span>
-      {[0.5, 1, 1.5, 2, 2.5, 3, 3.5, 4, 4.5, 5].map((v) => (
+      {[1, 2, 3, 4, 5].map((v) => {
+        const isCurrent = value === v || value === v - 0.5;
+        const nextVal = value === v ? v - 0.5 : v;
+        return (
          <button
            key={v}
            type="button"
-          onClick={() => onChange(v)}
-          className={`w-6 h-6 text-xs rounded border ${
-            value === v
-              ? "bg-yellow-500 text-white border-yellow-600"
-              : "bg-white text-gray-600 border-gray-300 hover:border-yellow-400"
-          }`}
+            role="radio"
+            aria-checked={value >= v - 0.5 && value <= v}
+            aria-label={`${nextVal}점`}
+            onClick={() => onChange(nextVal)}
+            // #281 — 최소 터치 영역 44×44
+            className="min-w-[44px] min-h-[44px] flex items-center justify-center touch-manipulation"
+            title={`${nextVal}점`}
          >
-          {v}
+            <span className={`text-xl ${v <= value ? "text-yellow-500" : v - 0.5 === value ? "text-yellow-400" : "text-gray-300"}`}>
+              {v <= value ? "★" : v - 0.5 === value ? "⯨" : "☆"}
+            </span>
          </button>
-      ))}
+        );
+      })}
+      {value > 0 && <span className="text-xs text-yellow-600 font-medium ml-1">{value}</span>}
    </div>
  );
 }
@@ -170,29 +153,42 @@ export default function ReviewSection({ restaurantId }: ReviewSectionProps) {
    ? reviews.find((r) => r.user_id === user.id)
    : null;

+  // #281 — API 실패 시 unhandled rejection 방지 + 사용자 피드백
  const handleCreate = async (data: {
    rating: number;
    review_text?: string;
    visited_at?: string;
  }) => {
+    try {
      await api.createReview(restaurantId, data);
      setShowForm(false);
      loadReviews();
+    } catch (e) {
+      alert(`리뷰 작성 실패: ${e instanceof Error ? e.message : String(e)}`);
+    }
  };

  const handleUpdate = async (
    reviewId: string,
    data: { rating: number; review_text?: string; visited_at?: string }
  ) => {
+    try {
      await api.updateReview(reviewId, data);
      setEditingId(null);
      loadReviews();
+    } catch (e) {
+      alert(`리뷰 수정 실패: ${e instanceof Error ? e.message : String(e)}`);
+    }
  };

  const handleDelete = async (reviewId: string) => {
    if (!confirm("리뷰를 삭제하시겠습니까?")) return;
+    try {
      await api.deleteReview(reviewId);
      loadReviews();
+    } catch (e) {
+      alert(`리뷰 삭제 실패: ${e instanceof Error ? e.message : String(e)}`);
+    }
  };

  return (
@@ -216,7 +212,7 @@ export default function ReviewSection({ restaurantId }: ReviewSectionProps) {
        <>
          {reviewCount > 0 && avgRating !== null && (
            <div className="flex items-center gap-2 mb-3 text-sm">
-              <StarDisplay rating={Math.round(avgRating * 2) / 2} />
+              <Stars rating={Math.round(avgRating * 2) / 2} />
              <span className="font-medium">{avgRating.toFixed(1)}</span>
              <span className="text-gray-500">({reviewCount}개)</span>
            </div>
@@ -270,7 +266,7 @@ export default function ReviewSection({ restaurantId }: ReviewSectionProps) {
                        <span className="text-sm font-medium">
                          {review.user_nickname || "익명"}
                        </span>
-                        <StarDisplay rating={review.rating} />
+                        <Stars rating={review.rating} />
                        <span className="text-xs text-gray-400">
                          {new Date(review.created_at).toLocaleDateString(
                            "ko-KR"
--- a/frontend/src/components/Stars.tsx
+++ b/frontend/src/components/Stars.tsx
@@ -0,0 +1,37 @@
+// #281 공통 별점 컴포넌트 — ReviewSection/MemoSection/MyReviewsList 재사용.
+// 0.5 단위 시각 구분: 빈 별 위에 황색 절반 별을 절대배치 + clip으로 표시.
+
+interface StarsProps {
+  rating: number; // 0~5, 0.5 단위
+  size?: "sm" | "md";
+  showNumber?: boolean;
+  className?: string;
+}
+
+export default function Stars({ rating, size = "sm", showNumber = false, className = "" }: StarsProps) {
+  const r = Math.max(0, Math.min(5, rating));
+  const textSize = size === "md" ? "text-base" : "text-sm";
+  return (
+    <span className={`inline-flex items-center gap-0.5 ${textSize} ${className}`} aria-label={`${r}점`}>
+      {[1, 2, 3, 4, 5].map((i) => {
+        const full = r >= i;
+        const half = !full && r >= i - 0.5;
+        return (
+          <span key={i} className="relative inline-block leading-none">
+            <span className="text-gray-300">★</span>
+            {(full || half) && (
+              <span
+                aria-hidden="true"
+                className="absolute inset-0 text-yellow-500 overflow-hidden"
+                style={{ width: full ? "100%" : "50%" }}
+              >
+                ★
+              </span>
+            )}
+          </span>
+        );
+      })}
+      {showNumber && r > 0 && <span className="text-xs text-yellow-600 font-medium ml-1">{r}</span>}
+    </span>
+  );
+}