Files
life-helper/app/test/domain/ai/suggest_frame_test.dart
joungmin 1e019c6dc7 [Developer] #215 AC2/AC4/AC6 fixes after QA reject
QA 1차 (커밋 6ab4c0d 검증) 에서 3건 AC 미충족 → 03-Developer 반려.
본 커밋은 그 3건을 해결한다.

AC6 — _AiSuggestButton 가시성 분기 분리:
- optIn=false → 숨김 유지
- optIn=true && !ready → 노출 + disabled + Tooltip("AI 도움을 먼저 켜주세요")
- optIn=true && ready → enabled
AC5 보완: 후보의 c.level 직접 전달 (이전 "나는" 휴리스틱 제거).
FrameSuggestionDialog.show 반환 타입 String? → FrameCandidate?.

AC4 — L2:2 + L3:1 분포 강제:
- few_shot prompt 에 "정확히 L2 2개 + L3 1개" 명시
- suggestFrame 결과를 _shapeDistribution(l2Quota=2, l3Quota=1) 로 후처리
- 부족분은 패딩 X (graceful: UI 가 더 적은 카드만 표시)

AC2 — 다운로드 진행률 + 일시정지/재개 UI:
- ModelDownloadController (StateNotifier<DownloadProgress?>)
  · start() / pause() / resume() / cancel()
  · pause() 는 subscription 만 cancel, .tmp + meta_kv 유지 → resume 시 Range header 로 이어받음
- AiSettingsController.setOptIn(true) → controller.start() 자동 호출
- SettingsScreen 에 _DownloadProgressTile 추가
  · LinearProgressIndicator + bytes/total + 일시정지/재개/다시 시도 토글

회귀 테스트 9건 신규:
- test/ui/ai_suggest_button_visibility_test.dart (4): AC6 4상태 (hidden / disabled+tooltip × missing/downloading / enabled)
- test/state/model_download_controller_test.dart (3): opt-in→start, pause→paused, cancel→idle
- test/domain/ai/suggest_frame_test.dart (+3): AC4 분포 케이스 3개 (기존 take(3) 테스트 대체)

검증:
- flutter analyze → No issues found
- flutter test → 71 tests pass (62 → 71, +9 신규)
- flutter build apk --debug → 성공 (8.8s)

OQ-1 (모델 URL+SHA) 미해결 유지. MockLlmService 기본 주입 + placeholder URL 다운로드는 여전히 실패하지만, UI/스트림 wiring 은 모두 검증됨.

Refs #215

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-06-12 12:30:16 +09:00

212 lines
6.0 KiB
Dart

import 'package:flutter_test/flutter_test.dart';
import 'package:life_helper/data/ai/llm_service.dart';
import 'package:life_helper/domain/ai/frame_candidate.dart';
import 'package:life_helper/domain/ai/suggest_frame.dart';
import 'package:life_helper/domain/models/frame_pattern.dart';
import 'package:life_helper/domain/models/habit.dart';
final _patterns = <FramePatternModel>[
const FramePatternModel(
id: 'fp_alcohol',
domain: 'drink',
avoidanceKeyword: '술 끊기',
l0Example: '술 끊기',
l2Suggestion: '무알콜',
l3Identity: '맑은 정신',
),
];
const _input = SuggestFrameInput(
rawText: '술 끊고 싶어',
habitType: HabitType.breakHabit,
);
void main() {
test('happy path: returns up to 3 validated candidates', () async {
final llm = MockLlmService();
await llm.load();
llm.enqueueResponse({
'candidates': [
{'level': 'L2', 'framed_text': '저녁엔 무알콜 음료', 'confidence': 0.9},
{'level': 'L3', 'framed_text': '나는 맑은 정신의 사람이다'},
{'level': 'L2', 'framed_text': '주말엔 운동 우선'},
],
});
final result = await suggestFrame(
_input,
llm: llm,
framePatterns: _patterns,
);
expect(result, hasLength(3));
expect(result[0].level, FrameLevel.l2);
});
test('L0/L1 candidates discarded by validateFrameLevel', () async {
final llm = MockLlmService();
await llm.load();
llm.enqueueResponse({
'candidates': [
{'level': 'L0', 'framed_text': '술 안 마시기'},
{'level': 'L1', 'framed_text': '음주 중단'},
{'level': 'L2', 'framed_text': '무알콜 마시기'},
],
});
final result = await suggestFrame(
_input,
llm: llm,
framePatterns: _patterns,
);
expect(result, hasLength(1));
expect(result.first.level, FrameLevel.l2);
});
test('timeout → empty list (graceful)', () async {
final llm = MockLlmService();
await llm.load();
llm.responseDelay = const Duration(milliseconds: 200);
llm.enqueueResponse({
'candidates': [
{'level': 'L2', 'framed_text': '무알콜'},
],
});
final result = await suggestFrame(
_input,
llm: llm,
framePatterns: _patterns,
timeout: const Duration(milliseconds: 50),
);
expect(result, isEmpty);
});
test('StateError (not loaded) → empty list (graceful)', () async {
final llm = MockLlmService(); // not loaded
final result = await suggestFrame(
_input,
llm: llm,
framePatterns: _patterns,
);
expect(result, isEmpty);
});
test('malformed JSON → empty list (graceful)', () async {
final llm = MockLlmService();
await llm.load();
llm.enqueueResponse({'foo': 'bar'}); // no candidates key
final result = await suggestFrame(
_input,
llm: llm,
framePatterns: _patterns,
);
expect(result, isEmpty);
});
test('empty rawText → llm not called', () async {
final llm = MockLlmService();
await llm.load();
final result = await suggestFrame(
const SuggestFrameInput(
rawText: ' ',
habitType: HabitType.breakHabit,
),
llm: llm,
framePatterns: _patterns,
);
expect(result, isEmpty);
expect(llm.callCount, 0);
});
test('rawText > 200 chars → empty list, llm not called', () async {
final llm = MockLlmService();
await llm.load();
final result = await suggestFrame(
SuggestFrameInput(
rawText: 'a' * 201,
habitType: HabitType.breakHabit,
),
llm: llm,
framePatterns: _patterns,
);
expect(result, isEmpty);
expect(llm.callCount, 0);
});
test('graceful: arbitrary throw is caught', () async {
final llm = MockLlmService();
await llm.load();
llm.enqueueError(Exception('boom'));
final result = await suggestFrame(
_input,
llm: llm,
framePatterns: _patterns,
);
expect(result, isEmpty);
});
test('AC4: L2-only input shaped to L2 quota (2), no padding with L3',
() async {
final llm = MockLlmService();
await llm.load();
llm.enqueueResponse({
'candidates': [
{'level': 'L2', 'framed_text': 'a'},
{'level': 'L2', 'framed_text': 'b'},
{'level': 'L2', 'framed_text': 'c'},
{'level': 'L2', 'framed_text': 'd'},
{'level': 'L2', 'framed_text': 'e'},
],
});
final result = await suggestFrame(
_input,
llm: llm,
framePatterns: _patterns,
);
expect(result, hasLength(2));
expect(result.every((c) => c.level == FrameLevel.l2), isTrue);
});
test('AC4: L3-only input shaped to L3 quota (1)', () async {
final llm = MockLlmService();
await llm.load();
llm.enqueueResponse({
'candidates': [
{'level': 'L3', 'framed_text': '나는 운동인이다'},
{'level': 'L3', 'framed_text': '나는 건강한 사람이다'},
{'level': 'L3', 'framed_text': '나는 일찍 자는 사람이다'},
],
});
final result = await suggestFrame(
_input,
llm: llm,
framePatterns: _patterns,
);
expect(result, hasLength(1));
expect(result.single.level, FrameLevel.l3);
});
test('AC4: mixed L2:3 + L3:2 input shaped to exactly L2:2 + L3:1',
() async {
final llm = MockLlmService();
await llm.load();
llm.enqueueResponse({
'candidates': [
{'level': 'L2', 'framed_text': 'L2-A'},
{'level': 'L3', 'framed_text': '나는 A'},
{'level': 'L2', 'framed_text': 'L2-B'},
{'level': 'L3', 'framed_text': '나는 B'},
{'level': 'L2', 'framed_text': 'L2-C'},
],
});
final result = await suggestFrame(
_input,
llm: llm,
framePatterns: _patterns,
);
expect(result, hasLength(3));
expect(result.where((c) => c.level == FrameLevel.l2).length, 2);
expect(result.where((c) => c.level == FrameLevel.l3).length, 1);
// Order preserves original LLM-emitted ordering
expect(result.map((c) => c.framedText).toList(),
['L2-A', '나는 A', 'L2-B']);
});
}